✨ Add task and test (#2208) #2219
Conversation
WalkthroughA new contest prefix mapping for "caddi2018b" was added to the ABC-like contests in the utility file. Corresponding test coverage was introduced to verify that "CADDi 2018 for Beginners" is recognized as an ABC-like contest. No other logic or exported entities were changed. Changes
Sequence Diagram(s)sequenceDiagram
participant TestSuite
participant ContestUtils
TestSuite->>ContestUtils: Check contest type for "caddi2018b"
ContestUtils-->>TestSuite: Returns ContestType.ABC_LIKE
Assessment against linked issues
Poem
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Pull Request Overview
This pull request adds a new contest test case for "CADDi 2018 for Beginners" and updates the contest classification mapping accordingly.
- Adds a new test case to the abcLike array for contestId "caddi2018b".
- Updates the classifyContest function to include the "CADDi 2018 for Beginners" contest.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/test/lib/utils/test_cases/contest_type.ts | Adds a test case for "CADDi 2018 for Beginners" under ABC_LIKE. |
| src/lib/utils/contest.ts | Updates contest classification with the new contest entry. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
src/lib/utils/contest.ts (1)
97-103: Optional: Alphabetical ordering of ABC_LIKE entries
Reordering the mapping keys alphabetically (e.g., aising2020, caddi2018b, hhkb2020, …) can improve readability and simplify future diffs.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge Base: Disabled due to data retention organization setting
📒 Files selected for processing (2)
src/lib/utils/contest.ts(1 hunks)src/test/lib/utils/test_cases/contest_type.ts(1 hunks)
🧰 Additional context used
🧬 Code Graph Analysis (1)
src/test/lib/utils/test_cases/contest_type.ts (1)
src/lib/types/contest.ts (2)
ContestType(30-52)ContestType(55-55)
🔇 Additional comments (2)
src/lib/utils/contest.ts (1)
97-103: Add new ABC-like contest prefix for CADDi 2018
The entry'caddi2018b': 'CADDi 2018 for Beginners'correctly extends the ABC_LIKE mapping to cover the new contest. No further changes needed in the classification logic.src/test/lib/utils/test_cases/contest_type.ts (1)
189-194: Add test case for new CADDi 2018 contest
This test ensures thatcaddi2018bis recognized asContestType.ABC_LIKE, matching the updated mapping. Good alignment between implementation and coverage.
close #2208
Summary by CodeRabbit
New Features
Tests